5020da33

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

One command, so that checking and splitting cannot come apart

`routeros-check` had three subcommands, which meant a Dispatch, which meant
two of the three could be asked for on their own. `split` checked first, so
that was not a hole, but `list-problems` was a second way to ask what the
checker knows and the shape invited a third.

There is one command now and no Dispatch. It checks the file, and a file it
has nothing to say about earns a directory: the file itself, its two halves,
and the list of problems this knows how to find. A file it has something to
say about earns the report and nothing else, so there is no way at all to get
halves of a configuration nobody has read.

That also collapses a repetition. `checkedFor` ran the checks and `deployFor`
ran them again to get the halves; now the halves come from the same run, and
`deployFor` asks `checkedFor` for them rather than shelling out to the checker
a second time.

The build reads the problem list out of a run over a clean example, since
there is no longer a separate way to ask for it.

Total

12s

Created 1 month ago Started 1 month ago Finished 1 month ago

Timeline