3b486a74

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

Step over an annotation pragma rather than reading it as a subject

Naming the pragma's fact after what it annotates fixed the common case and
broke the uncommon one: where {-# ANN foo #-} sits above bar, the comment
above the pragma came out attached to foo, which is worse than the scope
holding nothing that it replaced, because a suppression written there is
silently scoped elsewhere.

An annotation is not a subject, so it gets its own DeclKind and attachment
walks past it. The name stays, because a name occurrence inside the pragma is
scoped by it, and a suppression for such a finding has to be writable where
the hint says to write it.
GitHub
e2e-added-rule-is-rune2e-artifacts-are-reade2e-choices-are-found-beside-the-repositorye2e-cleane2e-dirty-package-is-judged-failinge2e-dirty-project-is-judged-failinge2e-dirty-report-is-readablee2e-disabled-rule-is-not-rune2e-incomplete-artifacts-are-a-failuree2e-judging-nothing-failse2e-named-packages-are-every-packagee2e-no-packages-is-judged-failinge2e-no-store-paths-in-findingse2e-paths-are-repository-relativee2e-withheld-facts-faile2e-wrong-source-mapping-is-a-complainthlint-checkhopinionpre-commitreleaseshellweeder-checkconfiguredevShelldefaultx86_64-linux