$ /nix/store/9ypz3flqsrl5xl495mm8h645gadjsxi1-coreutils-9.11/bin/timeout --kill-after=15s 7200s /nix/store/23zk8sgzamrbmj1fday15szf7f2279s8-nix-2.34.7/bin/nix --extra-experimental-features nix-command --extra-experimental-features flakes --log-format internal-json build --no-link --print-out-paths git+https://github.com/NorfairKing/hopinion?ref=no-semigroup-on-text&rev=0e52e1defbb4d0ad38b6057697c167b529c1ec13&shallow=1#checks.x86_64-linux.e2e-dirty-report-is-readable --print-build-logs  Downloading cached lonely-hopinion from https://cache.staging.nix-ci.com Downloading cached thing-gen-hopinion from https://cache.staging.nix-ci.com Downloading cached hopinion from https://cache.staging.nix-ci.com Downloaded cached lonely-hopinion (53 KiB) in 61ms Progress: 0 of 6 built, 1 of 3 downloaded from cache (2 downloading) Downloaded cached thing-gen-hopinion (52 KiB) in 61ms Progress: 0 of 5 built, 2 of 3 downloaded from cache (1 downloading) Downloaded cached hopinion (31.8 MiB) in 244ms Progress: 0 of 4 built, 3 of 3 downloaded from cache Building /nix/store/i4ydbfb0j1m4026h0g30rz7b978ikzvd-thing-hopinion.drv [thing-hopinion] [error CommentBareTodo]: A bare TODO. Reference an issue or a URL, or do it. [thing-hopinion]  ╭──▶ thing/src/Thing.hs@3:1-3:58 [thing-hopinion]  │ [thing-hopinion]  3 │ -- TODO a bare marker, which is the module-level finding. [thing-hopinion]  • ┬──────────────────────────────────────────────────────── [thing-hopinion]  • ╰╸ A TODO needs an issue reference or a URL saying where the follow-up is tracked. [thing-hopinion]  • [thing-hopinion]  │ Note: A TODO nothing points at is a note nobody is holding. It reads like a plan, so the next reader assumes it is one, and it goes stale in place because nothing brings it back up. A reference makes it findable from wherever the work is actually tracked; doing it makes the note unnecessary. If it is neither tracked nor worth doing, the honest version is a comment that says what is missing and what would make it worth doing. [thing-hopinion]  │ Hint: To suppress, write this directly above line 4 of thing/src/Thing.hs, and say why: -- [allow:CommentBareTodo]  [thing-hopinion] ─────╯ [thing-hopinion]  [thing-hopinion] [error HsGenValidInGenPackage]: A GenValid instance outside a -gen package. [thing-hopinion]  ╭──▶ thing/src/Thing.hs@9:1-9:25 [thing-hopinion]  │ [thing-hopinion]  9 │ instance GenValid Widget [thing-hopinion]  • ┬─────────────────────── [thing-hopinion]  • ╰╸ A GenValid instance in a package's own library gets compiled into the executable. Move it to the matching -gen package. [thing-hopinion]  • [thing-hopinion]  │ Note: A generator is test code, and an instance in the library is linked into everything that depends on the library, so the shipped executable carries QuickCheck and the generators with it. The -gen package exists so that dependency stops at the test suite, which is also what keeps a generator free to be as slow or as elaborate as the property needs. [thing-hopinion]  │ Hint: To suppress, write this directly above line 9 of thing/src/Thing.hs, and say why: -- [allow:HsGenValidInGenPackage]  [thing-hopinion] ─────╯ [thing-hopinion:post-build] Uploading to the NixCI staging cache: /nix/store/hr0fnhwhbps6w2pswsa6skngzipz9hnk-thing-hopinion [thing-hopinion:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [thing-hopinion:post-build] copying 1 paths... [thing-hopinion:post-build] copying path '/nix/store/hr0fnhwhbps6w2pswsa6skngzipz9hnk-thing-hopinion' to 'https://cache.staging.nix-ci.com'... [thing-hopinion:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [thing-hopinion:post-build] copying 0 paths... Uploaded thing-hopinion in 1.2s Progress: 1 of 4 built, 3 of 3 downloaded from cache Built thing-hopinion in 1.4s Building /nix/store/waiz3kjajwsjfkgj70qppbga0939l9qr-hopinion-project.drv [hopinion-project] [error HsGenValidInGenPackage]: A GenValid instance outside a -gen package. [hopinion-project]  ╭──▶ lonely/src/Lonely.hs@8:1-8:25 [hopinion-project]  │ [hopinion-project]  8 │ instance GenValid Orphan [hopinion-project]  • ┬─────────────────────── [hopinion-project]  • ╰╸ A GenValid instance in a package's own library gets compiled into the executable. Move it to the matching -gen package. [hopinion-project]  • [hopinion-project]  │ Note: A generator is test code, and an instance in the library is linked into everything that depends on the library, so the shipped executable carries QuickCheck and the generators with it. The -gen package exists so that dependency stops at the test suite, which is also what keeps a generator free to be as slow or as elaborate as the property needs. [hopinion-project]  │ Hint: To suppress, write this directly above line 8 of lonely/src/Lonely.hs, and say why: -- [allow:HsGenValidInGenPackage]  [hopinion-project] ─────╯ [hopinion-project]  [hopinion-project] [error TestGenValidSpecPerGenValid]: No genValidSpec @Orphan anywhere, and there is no lonely-gen for it to be written in. [hopinion-project]  ╭──▶ lonely/src/Lonely.hs@8:1-8:25 [hopinion-project]  │ [hopinion-project]  8 │ instance GenValid Orphan [hopinion-project]  • ┬─────────────────────── [hopinion-project]  • ╰╸ A GenValid instance creates an obligation: genValidSpec @T must be called in the test suite of that package's gen package. [hopinion-project]  • [hopinion-project]  │ Note: A generator nothing runs is a generator nobody has checked. genValid can produce values the type's own Validity instance rejects, and shrinkValid can shrink to them, and every property built on it inherits that quietly: the failures it reports are about values the code was never meant to see. genValidSpec asserts exactly the two things the instance promises, and it is one line. The spec belongs to the package that declares the instance, because a spec written next door disappears the day that other package stops mentioning the type. [hopinion-project]  │ Hint: To suppress, write this directly above line 8 of lonely/src/Lonely.hs, and say why: -- [allow:TestGenValidSpecPerGenValid]  [hopinion-project] ─────╯ [hopinion-project]  [hopinion-project] [error CommentBareTodo]: A bare TODO. Reference an issue or a URL, or do it. [hopinion-project]  ╭──▶ thing/src/Thing.hs@3:1-3:58 [hopinion-project]  │ [hopinion-project]  3 │ -- TODO a bare marker, which is the module-level finding. [hopinion-project]  • ┬──────────────────────────────────────────────────────── [hopinion-project]  • ╰╸ A TODO needs an issue reference or a URL saying where the follow-up is tracked. [hopinion-project]  • [hopinion-project]  │ Note: A TODO nothing points at is a note nobody is holding. It reads like a plan, so the next reader assumes it is one, and it goes stale in place because nothing brings it back up. A reference makes it findable from wherever the work is actually tracked; doing it makes the note unnecessary. If it is neither tracked nor worth doing, the honest version is a comment that says what is missing and what would make it worth doing. [hopinion-project]  │ Hint: To suppress, write this directly above line 4 of thing/src/Thing.hs, and say why: -- [allow:CommentBareTodo]  [hopinion-project] ─────╯ [hopinion-project]  [hopinion-project] [error HsGenValidInGenPackage]: A GenValid instance outside a -gen package. [hopinion-project]  ╭──▶ thing/src/Thing.hs@9:1-9:25 [hopinion-project]  │ [hopinion-project]  9 │ instance GenValid Widget [hopinion-project]  • ┬─────────────────────── [hopinion-project]  • ╰╸ A GenValid instance in a package's own library gets compiled into the executable. Move it to the matching -gen package. [hopinion-project]  • [hopinion-project]  │ Note: A generator is test code, and an instance in the library is linked into everything that depends on the library, so the shipped executable carries QuickCheck and the generators with it. The -gen package exists so that dependency stops at the test suite, which is also what keeps a generator free to be as slow or as elaborate as the property needs. [hopinion-project]  │ Hint: To suppress, write this directly above line 9 of thing/src/Thing.hs, and say why: -- [allow:HsGenValidInGenPackage]  [hopinion-project] ─────╯ [hopinion-project]  [hopinion-project] [error TestGenValidSpecPerGenValid]: No genValidSpec @Widget anywhere in thing-gen's test suite. [hopinion-project]  ╭──▶ thing/src/Thing.hs@9:1-9:25 [hopinion-project]  │ [hopinion-project]  9 │ instance GenValid Widget [hopinion-project]  • ┬─────────────────────── [hopinion-project]  • ╰╸ A GenValid instance creates an obligation: genValidSpec @T must be called in the test suite of that package's gen package. [hopinion-project]  • [hopinion-project]  │ Note: A generator nothing runs is a generator nobody has checked. genValid can produce values the type's own Validity instance rejects, and shrinkValid can shrink to them, and every property built on it inherits that quietly: the failures it reports are about values the code was never meant to see. genValidSpec asserts exactly the two things the instance promises, and it is one line. The spec belongs to the package that declares the instance, because a spec written next door disappears the day that other package stops mentioning the type. [hopinion-project]  │ Hint: To suppress, write this directly above line 9 of thing/src/Thing.hs, and say why: -- [allow:TestGenValidSpecPerGenValid]  [hopinion-project] ─────╯ [hopinion-project:post-build] Uploading to the NixCI staging cache: /nix/store/xzr8bv5i0c186fj4l9mw56k7hamj8mj9-hopinion-project [hopinion-project:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [hopinion-project:post-build] copying 1 paths... [hopinion-project:post-build] copying path '/nix/store/xzr8bv5i0c186fj4l9mw56k7hamj8mj9-hopinion-project' to 'https://cache.staging.nix-ci.com'... [hopinion-project:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [hopinion-project:post-build] copying 0 paths... Uploaded hopinion-project in 1.2s Progress: 2 of 4 built, 3 of 3 downloaded from cache Built hopinion-project in 1.6s Building /nix/store/8fwfq47hpz0d0q4xdpmnzcbhib83jrvp-e2e-dirty-report-is-readable.drv [e2e-dirty-report-is-readable:post-build] Uploading to the NixCI staging cache: /nix/store/jjfdw5wsqxg51a8afvk0rbvvd6snjic5-e2e-dirty-report-is-readable [e2e-dirty-report-is-readable:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [e2e-dirty-report-is-readable:post-build] copying 1 paths... [e2e-dirty-report-is-readable:post-build] copying path '/nix/store/jjfdw5wsqxg51a8afvk0rbvvd6snjic5-e2e-dirty-report-is-readable' to 'https://cache.staging.nix-ci.com'... [e2e-dirty-report-is-readable:post-build] warning: 'warn-short-path-literals' is deprecated, use 'lint-short-path-literals = ignore' instead [e2e-dirty-report-is-readable:post-build] copying 0 paths... Uploaded e2e-dirty-report-is-readable in 692ms Progress: 3 of 4 built, 3 of 3 downloaded from cache Built e2e-dirty-report-is-readable in 746ms Progress: 4 of 4 built, 3 of 3 downloaded from cache /nix/store/jjfdw5wsqxg51a8afvk0rbvvd6snjic5-e2e-dirty-report-is-readable Build succeeded.