36fe821e

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

Say what the wrapper test cannot tell apart

The clean case for leaving a named constructor alone is that it holds what was
not understood and the renderer makes the sentence, and good.hs said so while
showing a renderer that handed its payload straight back. That is the reported
shape with a constructor name that does not echo, so the example argued against
itself.

It is also not a corner. Of the fourteen one-constructor wrappers this rule
leaves alone across nix-ci8, smos, salsa, kronor, sydtest, validity and
graphql-engine, eleven render by building a sentence around their payload and
three are id: SecretNameParseError, UsernameParseError and
EventPayloadParseError hold the message itself.

What decides it is the renderer, which is a module away from the declaration
and not something this reads. So the comment now says that the test is the
wrapper it can be sure of, and that what it misses is a type named better than
it is.

Total

9s

Created 3 weeks ago Started 3 weeks ago Finished 3 weeks ago

Timeline