743fa02c

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

ical-recurrence: keep the week day of a numeric ByDay

@
The BYDAY rule part
MUST NOT be specified with a numeric value with the FREQ rule part
set to YEARLY when the BYWEEKNO rule part is specified.
@

The number is meaningless once BYWEEKNO has fixed the week, so discard
the number and keep the week day rather than discarding the rule part.

Dropping it entirely was worse than ignoring the rule part: with no week
days left, the BYWEEKNO branch of yearlyDayCandidate falls back to all of
Monday to Sunday, which widens the recurrence set to every day of the
week instead of narrowing it.

Suite timing

Time to Start Worker time Duration Time to finish Idle
Config 11s 1s 1s 13s 11s
Eval 18s 14s 14s 33s 4s
Build 32s 2m35s - - 26s
Suite 11s 2m52s - - 19m14s