9b73b84b

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

ical-recurrence: keep the week day of a numeric ByDay

@
The BYDAY rule part
MUST NOT be specified with a numeric value with the FREQ rule part
set to YEARLY when the BYWEEKNO rule part is specified.
@

The number is meaningless once BYWEEKNO has fixed the week, so discard
the number and keep the week day rather than discarding the rule part.

Dropping it entirely was worse than ignoring the rule part: with no week
days left, the BYWEEKNO branch of yearlyDayCandidate falls back to all of
Monday to Sunday, which widens the recurrence set to every day of the
week instead of narrowing it.

Suite timing

Time to Start Worker time Duration Time to finish Idle
Config 3s 2s 2s 5s 3s
Eval 15s 11s 11s 27s 9s
Build 26s 0s - - 0s
Suite 3s 13s - - 18m20s