efa36252

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

Drop redundant 'rest' argument from sqitch spec combinators

sqitchPostgresqlSpec and sqitchPersistentPostgresqlSpec used to take a
trailing 'TestDef outers a' continuation, returning 'TestDef outers a'.
But the result type is already in the TestDefM monad, so callers can
just sequence with 'do' or '>>'. The continuation argument adds no
power, only ceremony.

  Before: sqitchPostgresqlSpec settings (pure ())
          sqitchPersistentPostgresqlSpec settings (pure ())

  After:  sqitchPostgresqlSpec settings
          sqitchPersistentPostgresqlSpec settings

For callers that want to add tests after the sanity checks:

  do
    sqitchPostgresqlSpec settings
    describe "my other tests" ...

Existing placeholder 'it' blocks in the test suites are dropped since
they were only there to satisfy the now-removed continuation argument.
Test counts go 21→19 and 6→5 accordingly.

Suite timing

Time to Start Worker time Duration Time to finish
Config 0s 2s 2s 2s
Eval 3s 43s 43s 46s
Build 10s 55s 31s 42s
Test - - - -
Deploy - - - -
Suite 0s 1m42s 46s 46s

Timeline

0s10s20s30s40s