55ed397d

By: Tom Sydney Kerckhove <syd@cs-syd.eu>

warp: dispatch every accept() errno in the same list

Two of the four cases were hiding. EBADF was decided by a trailing
if-then-else inside the fallthrough, so the branch that ends the loop
quietly was not visible among the guards. ECONNABORTED sat beside
isQueuedConnectionError with an || when it is one of them: a peer that goes
away before it can be accepted is precisely an error about one queued
connection, which is why it was already retried.

The multi-way if now lists all four and the fallthrough only throws.

The EBADF guard costs two duplicated lines, the exhaustion reset and the
exception report. That seemed better than a helper standing between a guard
and what it does.

Timeline